Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove descriptiveness check #49

Merged

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Jan 11, 2023

Remove descriptiveness check. PR reviewers can ask for more details on a per PR basis, and requiring descriptions meet a minimum length leads to PR authors copying and pasting repeated text into the description to make the check pass. There are definitely valid times when a description is not needed (the title is sufficient).

Signed-off-by: Andy Goldstein andy.goldstein@redhat.com

Remove descriptiveness check. PR reviewers can ask for more details on a
per PR basis, and requiring descriptions meet a minimum length leads to
PR authors copying and pasting repeated text into the description to
make the check pass. There are definitely valid times when a description
is not needed (the title is sufficient).

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2023
@ncdc
Copy link
Contributor Author

ncdc commented Jan 11, 2023

/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2023
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@ncdc ncdc changed the title Remove descriptiveness check ⚠️ Remove descriptiveness check Jan 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit e90dee8 into kubernetes-sigs:master Jan 11, 2023
@sbueringer
Copy link
Member

sbueringer commented Jan 11, 2023

Thank you!!

(should have done this instead of disabling the GitHub action for cherry-pick bot PRs when we ran into this issue 😂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants